This repository has been archived by the owner on Nov 10, 2022. It is now read-only.
[IT-435] upgrade to use Sceptre ver 2 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaro0508
force-pushed
the
upgrade-sceptre
branch
from
fe8d009
to
7372605
Compare
thomasyu888
reviewed
Jan 29, 2019
|
yes, it does. will do next |
Upgrade from Sceptre 1.x to 2.x because V1 is end of life[1]. Followed the migration guide[2] to do the upgrade. [1] Sceptre/sceptre#593 [2] https://github.com/cloudreach/sceptre/wiki/Migration-Guide:-V1-to-V2
zaro0508
force-pushed
the
upgrade-sceptre
branch
from
7372605
to
e61a005
Compare
thomasyu888
reviewed
Jan 29, 2019
| - pip install git+git://github.com/zaro0508/sceptre@issue-586 | ||
| - pip install git+git://github.com/zaro0508/sceptre-ssm-resolver.git | ||
| - pip install git+git://github.com/zaro0508/sceptre-date-resolver.git | ||
| - pip install git+git://github.com/Sage-Bionetworks/sceptre-provisioner-hooks.git |
There was a problem hiding this comment.
What are all these pip installs?
There was a problem hiding this comment.
sceptre@issue-586 is my fork of sceptre fix to Sceptre/sceptre#586
the others are installs of sceptre resolvers that i created. the ssm-resolver and date-resolver will be upstream soon.
Sceptre/sceptre#602
Sceptre/sceptre#608
The sceptre-provisioner-hooks is very specific to sage so won't be upstream.
thomasyu888
reviewed
Jan 29, 2019
| @@ -16,5 +16,5 @@ parameters: | |||
| JcSystemsGroupId: !ssm /infra/JcSystemsGroupId | |||
| hooks: | |||
| after_create: | |||
| - !notify_ec2 | |||
| - !ec2_notify {{stack_group_config.aws_account_name}} {{stack_group_config.aws_account_email}} | |||
There was a problem hiding this comment.
Wheres this 'stack_group_config' coming from?
There was a problem hiding this comment.
it's a reference to vars in config/config.yaml file. more info here: https://sceptre.cloudreach.com/latest/docs/stack_group_config.html
thomasyu888
approved these changes
Jan 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade from Sceptre 1.x to 2.x because V1 is end of life[1].
Followed the migration guide[2] to do the upgrade.
[1] Sceptre/sceptre#593
[2] https://github.com/cloudreach/sceptre/wiki/Migration-Guide:-V1-to-V2