-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update annotations unit test #880
Conversation
@GiaJordan this looks good. But I am also wondering how did you figure it out that the sleep time should be 60 instead of 30? There's also this library here that we could use for retry |
Thanks for including the new library! There just needs to be enough time for one instance of the test to run and finish interacting with the entities on synapse before another does so. |
This reverts commit 2deed97.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Looks good to me!
If the issue persists despite enabling retries, you could also look into forcing the tests to run sequentially in GitHub Actions (docs).
I also noticed that redundant tests are run for PRs, which might be contributing to clashes between them when accessing Synapse (see screenshot below). This could be avoided by refining the on:
field for the test.yml
CI workflow (docs).
This is something you could tweak in this PR. For example, the following config would run the CI workflow on pushes to the main
branch as well as all PRs. I haven't tested this snippet, so it might require some tweaking. If you do made this change, we should be see right away whether there are duplicate checks here.
on:
push:
branches: [main]
pull_request:
Screenshot of Redundant Tests
@BrunoGrandePhD thank you for reviewing! I'll keep those fixes in mind if issues arise with the tests again! |
Builds on #862. When two instances of the tests are running, an error can arise if they try to modify the same synapse entity concurrently. Waiting before trying again resolves. Implement tenacity to jitter instances of the tests and manage competition for shared resources. Annotations unit test now uses single dataset and manifest.