Testbed module #38
Merged
Testbed module #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add functions for retrieving and submitting workflow checker jobs to testbed module (remove from orchestrator module).
Update functions and logic in the testbed module to prepare and create new workflow checker jobs as test params (JSON), submitted to evaluation queues. Information about how to run the actual workflow and post the WES request will be associated directly with the evaluation queue. See #33
Pull Request Test Coverage Report for Build 177
💛 - Coveralls |
Use the bravado loader class to construct a spec dict from the swagger yaml, then load the client from the spec with the proper origin url specified. Loading 'from_url' with a local file doesn't provide an option to specify the origin url and instead uses the relative local path (even with the http client provided).
Use the bravado loader class to construct a spec dict from the swagger yaml, then load the client from the spec with the proper origin url specified. Loading 'from_url' with a local file doesn't provide an option to specify the origin url and instead uses the relative local path (even with the http client provided).
Include argument for named WES client when 'load_wes_client' is called by the wrapper class. Use a global variable to set the current option for client library.
Fix any calls to retrieve queue configs, and use only TRS or WES ID to initiate respective instances while checking testbed services for connectivity.
Add function for retrieving workflow data for a queue from TRS when not provided; need to add steps to convert this info into a valid WES request next.
Use conftest.py to describe all test fixtures to avoid redundancy (and discrepancies) across modules.
Stick with unique queue identifiers for keys in the queue config, rather than workflow IDs or handles. Update variable names and accessor steps in assorted modules.
Update functions that were either mismatched with the latest WES spec or with the workflow-service wes_client library. Lots of changes made during live testing, not very well tracked. Also add test data and simplify app config (at least for version to be stored in repo).
Modify run and monitor functions in orchestrator module to increase consistency and reduce modification between levels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #33.