Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYNPY-816] Enable test_teams again #1011

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

BryanFauble
Copy link
Contributor

Problem:
https://sagebionetworks.jira.com/browse/SYNPY-816
Assertion error

Solution:
I enabled the test again

Testing:
I installed https://pypi.org/project/pytest-repeat/ and ran 100 times in parallel with 4 workers on my local machine

@BryanFauble BryanFauble requested a review from a team as a code owner November 8, 2023 22:28
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM!

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although - I will say, it doesn't look like we changed the logic within the tests, I wonder if there is actually a possibility that we get duplicated team names with "My Uniquely Named Team " + str(uuid.uuid4()) over time.

@BryanFauble
Copy link
Contributor Author

Although - I will say, it doesn't look like we changed the logic within the tests, I wonder if there is actually a possibility that we get duplicated team names with "My Uniquely Named Team " + str(uuid.uuid4()) over time.

@thomasyu888
https://en.wikipedia.org/wiki/Universally_unique_identifier#Collisions
"the probability to find a duplicate within 103 trillion version-4 UUIDs is one in a billion. "

@BryanFauble BryanFauble merged commit acbcf52 into develop Nov 8, 2023
35 checks passed
@BryanFauble BryanFauble deleted the SYNPY-816-test-teams branch November 8, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants