Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYNPY-1337] Adding note about unique .db file #1016

Merged
merged 3 commits into from
Nov 27, 2023
Merged

[SYNPY-1337] Adding note about unique .db file #1016

merged 3 commits into from
Nov 27, 2023

Conversation

BryanFauble
Copy link
Contributor

@BryanFauble BryanFauble commented Nov 27, 2023 •
edited
Loading

Problem:

  1. When running a migration for multiple projects/folders you cannot re-use the same .db file as there is a check that will prevent overwriting data for previous indexes.
  2. During long-running migrations we want to be notified on failure or success

Solution:

  1. Adding a best practice to specify a unique name per project/folder to migrate
  2. Added a syn.sendMessage to the script to notify on success or failure
    image

@BryanFauble BryanFauble requested a review from a team as a code owner November 27, 2023 16:53
BWMac
BWMac approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@BWMac BWMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

thomasyu888
thomasyu888 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM!

@BryanFauble BryanFauble merged commit 78f2ec5 into develop Nov 27, 2023
35 checks passed
@BryanFauble BryanFauble deleted the SYNPY-1337-unique-db-file-name branch November 27, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasyu888 thomasyu888 thomasyu888 approved these changes

@BWMac BWMac BWMac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BryanFauble @thomasyu888 @BWMac