Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Dockerfile to Correctly Install Dependencies #1019

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Updates Dockerfile to Correctly Install Dependencies #1019

merged 1 commit into from
Dec 1, 2023

Conversation

BWMac
Copy link
Contributor

@BWMac BWMac commented Nov 30, 2023

Problem:

Newer dependencies are not correctly installed when you run docker build . with the current Dockerfile.

Solution:

Update the Dockerfile to correctly install the dependencies.

@BWMac BWMac requested a review from a team as a code owner November 30, 2023 22:06
BryanFauble
BryanFauble approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making this change.

@BWMac BWMac merged commit aaef885 into develop Dec 1, 2023
35 checks passed
@BWMac BWMac deleted the bwmac/update_dockerfile branch December 1, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BryanFauble BryanFauble BryanFauble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BWMac @BryanFauble