Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYNPY-1336] Benchmarking upload with annotations #1021

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

BryanFauble
Copy link
Contributor

Problem:

  1. We did not have any information about stats when uploading files with annotations.
  2. Documentation around setting several pieces in the .synapseConfig was lacking

Solution:

  1. I updated the benchmark script to include adding annotations to the files.
  2. I added a document to describe the sections of the .synapseConfig and links to the file we had in source control.

Testing:
See results in the benchmark doc

@BryanFauble BryanFauble requested a review from a team as a code owner December 6, 2023 17:56
Copy link
Contributor

@BWMac BWMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BryanFauble BryanFauble merged commit 47f92af into develop Dec 7, 2023
14 of 16 checks passed
@BryanFauble BryanFauble deleted the SYNPY-1336-upload-benchmark-with-annotations branch December 7, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants