Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYNPY-1321] Download benchmark results #1024

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

BryanFauble
Copy link
Contributor

Problem:
We had no stats on download times for varying file counts and sizes

Solution:
Create a benchmark script and ran on an EC2 instance created through the service catalog. This led to interesting information when starting to go into higher thread counts with > 1GB files. Something with the size of the files led to a lot of instability; As a result my recommendation was to not exceed the default thread count for these larger file sizes.

@BryanFauble BryanFauble requested a review from a team as a code owner December 13, 2023 21:09
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM!

@BryanFauble BryanFauble merged commit 87dc25d into develop Dec 13, 2023
35 checks passed
@BryanFauble BryanFauble deleted the SYNPY-1321-benchmark-download branch December 13, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants