Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYNPY-1371] Doc fixes #1040

Merged
merged 1 commit into from
Jan 4, 2024
Merged

[SYNPY-1371] Doc fixes #1040

merged 1 commit into from
Jan 4, 2024

Conversation

BryanFauble
Copy link
Contributor

Problem:

  1. Jenny had a great idea to move the initial setup to the home page instead of tutorials
  2. Some links and formatting on a few pages was broken

Solution:
Implementing the changes

Testing:
Verified on docs site

@BryanFauble BryanFauble requested a review from a team as a code owner January 4, 2024 16:46
@pep8speaks
Copy link

Hello @BryanFauble! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 42:89: E501 line too long (110 > 88 characters)

Line 59:89: E501 line too long (109 > 88 characters)

BWMac
BWMac approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@BWMac BWMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the updates.

@BryanFauble BryanFauble merged commit 7c2f1fc into develop Jan 4, 2024
29 checks passed
@BryanFauble BryanFauble deleted the SYNPY-1371-documentation-fixes branch January 4, 2024 16:52
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BWMac BWMac BWMac approved these changes

@jaymedina jaymedina Awaiting requested review from jaymedina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BryanFauble @pep8speaks @BWMac