Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYNPY-1225] Support authToken only #1041

Merged
merged 8 commits into from
Jan 8, 2024
Merged

Conversation

BryanFauble
Copy link
Contributor

Problem:

  1. Authentication Token needs to be the only supported mechanism for using the Python Client

Solution:

  1. Removing apiKey, sessionToken, username/password
  2. Removing some dependencies on keyring
  3. Updating doc links
  4. regen the pipefile.lock
  5. Remove password from the encrypted credentials file

Testing:

  1. I did manual testing to verify that I could use my authToken to log in programmatically and via the CLI (synapse login and synapse config)
  2. Update of integration tests and unit tests to remove testing other methods and also using auth token only

@BryanFauble BryanFauble requested a review from a team as a code owner January 4, 2024 19:06
@pep8speaks
Copy link

pep8speaks commented Jan 4, 2024

Hello @BryanFauble! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 666:89: E501 line too long (90 > 88 characters)
Line 806:89: E501 line too long (91 > 88 characters)
Line 1048:89: E501 line too long (89 > 88 characters)
Line 1223:89: E501 line too long (89 > 88 characters)
Line 1235:89: E501 line too long (89 > 88 characters)
Line 1673:89: E501 line too long (91 > 88 characters)

Line 428:89: E501 line too long (93 > 88 characters)
Line 433:89: E501 line too long (99 > 88 characters)
Line 548:89: E501 line too long (90 > 88 characters)
Line 556:89: E501 line too long (90 > 88 characters)
Line 2040:89: E501 line too long (90 > 88 characters)

Line 40:89: E501 line too long (89 > 88 characters)
Line 48:89: E501 line too long (90 > 88 characters)
Line 169:89: E501 line too long (89 > 88 characters)
Line 170:89: E501 line too long (90 > 88 characters)
Line 178:89: E501 line too long (90 > 88 characters)
Line 214:89: E501 line too long (116 > 88 characters)
Line 215:89: E501 line too long (138 > 88 characters)
Line 216:89: E501 line too long (120 > 88 characters)
Line 217:89: E501 line too long (134 > 88 characters)

Line 13:1: F811 redefinition of unused 'Synapse' from line 12
Line 40:32: E711 comparison to None should be 'if cond is None:'

Line 150:89: E501 line too long (96 > 88 characters)

Comment last updated at 2024-01-08 17:37:19 UTC

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Love the simplification of code - I'm going to pre-approve since I just had some comments.

docs/tutorials/command_line_client.md Show resolved Hide resolved
docs/tutorials/command_line_client.md Show resolved Hide resolved
synapseclient/client.py Show resolved Hide resolved
synapseclient/core/credentials/cred_data.py Outdated Show resolved Hide resolved
synapseclient/client.py Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jan 8, 2024

@BryanFauble BryanFauble merged commit 7e31322 into develop Jan 8, 2024
38 checks passed
@BryanFauble BryanFauble deleted the SYNPY-1225-auth-token-only branch January 8, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants