-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synpy 1369] Migrate to Google style #1042
Conversation
Hello @danlu1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-01-11 07:43:30 UTC |
Update Pandas DataFrame link in table.py
Please add a description for the changes. I've usually followed this format: Problem this is addressing Solution to address the problem Testing (If applicable) |
Excellent work so far! Please re-request review when you are ready for another round. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work! Thanks for you attention on this.
remove <> for hyperlink in inline comment
remove <> for hyperlink in inline comment in sts_transfer.py
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Problem:
Some docstrings in the following modules are in Sphinx style or missing the Google Style docstrings.
synapseclient/client.py
synapseclient/table.py
synapseclient/core/cache.py
synapseclient/core/sts_transfer.py
synapseclient/core/upload/upload_functions.py
synapseutils/describe_functions.py
Solution:
Migrate docstring from Sphinx to Google Style and link some modules in corresponding markdown file.
Testing (If applicable):
N/A