Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYNPY-1412] Fixing typing issue in copy_functions #1048

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

jaymedina
Copy link
Collaborator

@jaymedina jaymedina commented Jan 22, 2024

problem

Importing Entity from entity.py was not working on Jupyter Notebook. This cell was executed after launching notebook off the latest develop branch on SynPy:

image

solution

The solution was to have the type hints refer to the Entity class which is already imported at the top of copy_functions.py instead of calling it again from synapseclient.entity.py.

testing & preview

With this change there are no import errors for synapseutils:

image

@jaymedina jaymedina self-assigned this Jan 22, 2024
@jaymedina jaymedina changed the title Fixing typing issue in copy_functions [SYNPY-1412] Fixing typing issue in copy_functions Jan 22, 2024
Copy link

sonarcloud bot commented Jan 22, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jaymedina jaymedina marked this pull request as ready for review January 22, 2024 16:50
@jaymedina jaymedina requested a review from a team as a code owner January 22, 2024 16:50
Copy link
Contributor

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jaymedina jaymedina merged commit 60be15b into develop Jan 22, 2024
38 checks passed
@jaymedina jaymedina deleted the SYNPY-1412-Entity-type branch January 22, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants