Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYNPY-1344] Remove return type hinting on decorator #1050

Merged
merged 1 commit into from
Jan 24, 2024
Merged

[SYNPY-1344] Remove return type hinting on decorator #1050

merged 1 commit into from
Jan 24, 2024

Conversation

BryanFauble
Copy link
Contributor

Problem:
Type hinting on functions wrapped in this decorator were not showing correctly.

Solution:
Remove type hinting

Testing:
image

@BryanFauble BryanFauble requested a review from a team as a code owner January 24, 2024 17:55
BWMac
BWMac approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@BWMac BWMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I can see the type hints when I hover on my end.

@BryanFauble BryanFauble merged commit cec3aa4 into develop Jan 24, 2024
28 of 29 checks passed
@BryanFauble BryanFauble deleted the fix-type-hinting-on-decorator branch January 24, 2024 18:01
@thomasyu888 thomasyu888 changed the title Remove return type hinting on decorator [SYNPY-1344] Remove return type hinting on decorator Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BWMac BWMac BWMac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BryanFauble @BWMac