Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYNPY-1344] Set client in conftest since login is not used in unit tests #1052

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

BryanFauble
Copy link
Contributor

Problem:

  1. The synapse_client parameter in the Synapse class is only initialized when using login - Which is ok for integration tests and normal operations, however, because we are not using login for unit tests I need to manually set the parameter

Solution:
Set the client in the conftest.py for unit tests

Testing:
Unit tests Brad/Bryan are developing

@BryanFauble BryanFauble requested a review from a team as a code owner January 24, 2024 22:42
Copy link

sonarcloud bot commented Jan 24, 2024

Copy link
Contributor

@BWMac BWMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I take it this removes the need to have the same line in each test?

@BryanFauble
Copy link
Contributor Author

Looks good. I take it this removes the need to have the same line in each test?

yes

@BryanFauble BryanFauble merged commit d457d35 into develop Jan 25, 2024
38 checks passed
@BryanFauble BryanFauble deleted the synpy-1344-set-client-in-synapse-class branch January 25, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants