Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYNPY-1347] Adds OOP Team Model #1053

Merged
merged 109 commits into from
Feb 1, 2024
Merged

[SYNPY-1347] Adds OOP Team Model #1053

merged 109 commits into from
Feb 1, 2024

Conversation

BWMac
Copy link
Contributor

@BWMac BWMac commented Jan 25, 2024 •
edited
Loading

Description:

This PR adds an OOP model for interacting with Teams in Synapse. It provides the ability to:

  • Create a team
  • Delete a team
  • Retrieve information about a team by using its ID number or team name
  • Retrieve information about a team's members
  • Invite new members to a team
  • View any unresolved invitations a team has sent to Synapse users

Notes:

  • To support specifically creating and deleting teams, corresponding functions were added to client.py
  • All new code has been tested with unit/integration tests where applicable
  • TeamMember and UserGroupHeader models were also created to be used in the composition of Team objects
  • A demo script oop_poc_team.py is included to showcase how a developer can interact with teams using the new model

@BryanFauble
OTEL Additions to what is/isn't a span
625b0ba
@BryanFauble
>= dependencies
6105a71
@BryanFauble
Add in document and script around benchmarking
cebe138
@BryanFauble
Code review feedback
89cd7c7
@BryanFauble
Link to tutorial section
40250fb
@BryanFauble
Adjust OTEL dependencies
dd0eeb0
@BryanFauble
Mark test as flaky
03cf453
@BryanFauble
Publish branch to remote
dcc29f0
@BryanFauble
Import File earlier
77a8d6b
@BryanFauble
Merge branch 'develop' into SYNPY-1322-OOP-POC
b27cf12
@BryanFauble
Support for annotations,cache syn client instance
244c69f
@BryanFauble
Remove httpx
55ee852
@BryanFauble
Merge branch 'develop' into SYNPY-1322-OOP-POC
65a1c70
@BryanFauble
Adding support for Table
57da4e1
@BryanFauble
Adding delete row note
5bdf4c4
@BryanFauble
Adding delete table
1a11b17
@BryanFauble
More example scripts
f988b5c
@BryanFauble
Remove comment
5d5f9f5
@BryanFauble
Prevent creating instance for calling class method
6b5b9af
@BryanFauble
Correcting OTEL context propogation
86a474e
@BryanFauble
Add note about assuming annotation type
dfbddcc
@BryanFauble
Merge branch 'develop' into SYNPY-1322-OOP-POC
6b74371
@BryanFauble
Adding more verbose examples for current project interface
84a5369
@BryanFauble
simplify the annotation interface (#1022)
d370b46
@BryanFauble
[SYNPY-1345] Migrate to mkdocstrings (#1023)
3aec4ff 
* Migrate to mkdocstrings
@BryanFauble
Making sticky nav tabs per team meeting
93bacca
@BryanFauble
Merge branch 'develop' into SYNPY-1322-OOP-POC
bbe905f
@BryanFauble
Remove content not needed
410de22
@BryanFauble
Remove content that is not needed
be9f193
@BryanFauble
Merge develop and consistency changes
cc049b0
BWMac and others added 4 commits January 29, 2024 15:08
BryanFauble
BryanFauble approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥

These changes look good to me!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

13 New issues
0 Security Hotspots
94.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

thomasyu888
thomasyu888 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM!

@BWMac BWMac merged commit 10f7ae6 into develop Feb 1, 2024
37 of 38 checks passed
@BWMac BWMac deleted the bwmac/SYNPY-1347/oop_team_model branch February 1, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasyu888 thomasyu888 thomasyu888 approved these changes

@BryanFauble BryanFauble BryanFauble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BWMac @pep8speaks @BryanFauble @thomasyu888