[SYNPY-1344] Adding activity model for OOP

[BryanFauble]

Problem:

1. We need to create an OOP approach to working with the Activity model.
2. Some documentation needed to be updated
3. Remove OTEL from the test scripts showing how the interfaces are working

Solution:

1. Creating the Activity model based off the Rest API
2. Updating documentation
3. Creating a test script

Testing:

1. Unit and integration tests
2. The oop_poc_activity.py script

[pep8speaks]

Hello @BryanFauble! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file synapseclient/client.py:

Line 2722:89: E501 line too long (111 > 88 characters)
Line 2723:89: E501 line too long (106 > 88 characters)
Line 2756:89: E501 line too long (111 > 88 characters)
Line 2757:89: E501 line too long (106 > 88 characters)
Line 2784:89: E501 line too long (111 > 88 characters)
Line 2785:89: E501 line too long (106 > 88 characters)
Line 2796:89: E501 line too long (90 > 88 characters)
Line 2797:89: E501 line too long (110 > 88 characters)
Line 2826:89: E501 line too long (111 > 88 characters)
Line 2827:89: E501 line too long (106 > 88 characters)

• In the file synapseclient/core/utils.py:

Line 1232:89: E501 line too long (89 > 88 characters)
Line 1233:89: E501 line too long (90 > 88 characters)
Line 1240:89: E501 line too long (97 > 88 characters)
Line 1244:89: E501 line too long (92 > 88 characters)

• In the file synapseclient/models/activity.py:

Line 31:89: E501 line too long (95 > 88 characters)
Line 89:89: E501 line too long (90 > 88 characters)
Line 90:89: E501 line too long (97 > 88 characters)
Line 111:89: E501 line too long (92 > 88 characters)
Line 183:89: E501 line too long (92 > 88 characters)
Line 241:89: E501 line too long (110 > 88 characters)
Line 306:89: E501 line too long (110 > 88 characters)
Line 344:89: E501 line too long (110 > 88 characters)

• In the file tests/integration/synapseclient/models/test_activity.py:

Line 214:14: F841 local variable 'ex' is assigned to but never used

• In the file tests/unit/synapseclient/models/unit_test_activity.py:

Line 25:89: E501 line too long (91 > 88 characters)
Line 41:89: E501 line too long (91 > 88 characters)
Line 63:89: E501 line too long (91 > 88 characters)
Line 79:89: E501 line too long (91 > 88 characters)

Comment last updated at 2024-01-26 17:06:39 UTC

[jaymedina]

Looks good at first glance, I made some small comments, most are just for clarity, feel free to ignore some of them.

[thomasyu888]

🔥 Wonderful PR. I left some comments, but I'm going to pre-approve. Most of them are Nits and/or potentially different Jira tickets.

[thomasyu888]

I'll leave it to the team to validate these in the feature branch. I will be running through these after they are merged into develop / client release, but awesome work here!

[sonarcloud]

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

12 New issues
0 Security Hotspots
82.6% Coverage on New Code
15.1% Duplication on New Code

See analysis details on SonarCloud