[SYNPY-448] allow changing Synapse name in changeFileMetaData

[danlu1]

Problem:

Python client doesn't allow changing Synapse name for file metadata

Solution:

Add a name argument to change_metadata in file.py and changeFileMetaData function in synapseutils

Testing:

Integration and unit testing are included in this PR

[pep8speaks]

Hello @danlu1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file synapseclient/models/file.py:

Line 495:89: E501 line too long (116 > 88 characters)
Line 587:89: E501 line too long (135 > 88 characters)
Line 590:89: E501 line too long (89 > 88 characters)
Line 591:89: E501 line too long (160 > 88 characters)
Line 592:89: E501 line too long (103 > 88 characters)

• In the file synapseutils/copy_functions.py:

Line 263:89: E501 line too long (131 > 88 characters)
Line 267:89: E501 line too long (161 > 88 characters)
Line 268:89: E501 line too long (99 > 88 characters)

• In the file tests/integration/synapseclient/models/test_file.py:

Line 699:89: E501 line too long (98 > 88 characters)

Comment last updated at 2024-02-12 17:39:17 UTC

[BryanFauble]

I am going to make 1 change here to put name at the end of the parameters being passed in - This is because if someone were using this function without explicit kwarguments then this would break their code.

[danlu1]

Good catch! Thanks @BryanFauble

[BryanFauble]

Thanks for the changed Dan!

[sonarcloud]

Quality Gate passed

Issues
5 New issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud