Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYNPY-1417] Updates for the annotation model #1081

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

BryanFauble
Copy link
Contributor

Problem:

  1. When using the annotations field you had to first set it to a dict to use it since the default was None.
  2. When using the annotations field it was not intuitive to set it to an empty dict to delete all annotations on an entity.

Solution:

  1. Updating the default for the annotation field to be an empty dict.
  2. Updating the logic around the annotation field such that if it is Empty or None it will be treated as a delete. It still means though that to delete annotations for an entity that is already stored in Synapse you'll need to do a "destructive" store (Meaning you .get() it then .store() it.

Testing:

  1. Verified with new and existing integration tests

@BryanFauble BryanFauble requested a review from a team as a code owner April 4, 2024 23:41
@BryanFauble BryanFauble merged commit ebc759c into develop Apr 9, 2024
36 of 38 checks passed
@BryanFauble BryanFauble deleted the SYNPY-1417-annotation-model-finishing-touches branch April 9, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants