Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYNPY-1474] Correct order of credentials in comment #1091

Merged
merged 2 commits into from
May 6, 2024

Conversation

BryanFauble
Copy link
Contributor

Problem:
The order of credentials being tried was incorrect in the comment

Solution:
Correct the comment to match the code from: https://github.com/Sage-Bionetworks/synapsePythonClient/blob/develop/synapseclient/core/credentials/credential_provider.py#L258

@BryanFauble BryanFauble requested a review from a team as a code owner May 6, 2024 18:25
@pep8speaks
Copy link

pep8speaks commented May 6, 2024

Hello @BryanFauble! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 212:89: E501 line too long (120 > 88 characters)
Line 213:89: E501 line too long (116 > 88 characters)
Line 214:89: E501 line too long (138 > 88 characters)

Comment last updated at 2024-05-06 18:26:51 UTC

@BryanFauble BryanFauble changed the title Correct order of credentials in comment [SYNPY-1474] Correct order of credentials in comment May 6, 2024
Copy link
Contributor

@danlu1 danlu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BryanFauble BryanFauble merged commit 3ebefeb into develop May 6, 2024
25 of 29 checks passed
@BryanFauble BryanFauble deleted the correct-credential-order branch May 6, 2024 18:34
Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants