Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYNPY-1456] Revert to old ubuntu #1092

Merged
merged 2 commits into from
May 7, 2024
Merged

[SYNPY-1456] Revert to old ubuntu #1092

merged 2 commits into from
May 7, 2024

Conversation

BryanFauble
Copy link
Contributor

Problem:

  1. Running integration tests in ubuntu-22.04 takes between 3-4 hours to complete.

Solution:

  1. Revert ubuntu versions for the GH runner

Testing:

  1. Verified after this change that a pipeline run only took ~30 minutes to complete

@BryanFauble BryanFauble requested a review from a team as a code owner May 7, 2024 17:31
jaymedina
jaymedina approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@jaymedina jaymedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! But hmm that's odd. Why do you think 22.04 Ubuntu slows this down by so much? On the ITCR side we have some Docker containers that run in Ubuntu 22.04

thomasyu888
thomasyu888 approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM - do you know why there might be such a big difference?

@BryanFauble
Copy link
Contributor Author

@thomasyu888 @jaymedina I'm not sure why we are seeing such a slowdown here. When I looked back at the runs it seemed like the majority of time was spent doing "nothing" where the next test was waiting to be run. Perhaps there is a bug with the new ubuntu version and with xdist that causes this.

@BryanFauble BryanFauble merged commit f07f170 into develop May 7, 2024
21 checks passed
@BryanFauble BryanFauble deleted the test-old-ubuntu branch May 7, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasyu888 thomasyu888 thomasyu888 approved these changes

@jaymedina jaymedina jaymedina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BryanFauble @thomasyu888 @jaymedina