Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYNPY-1470] Remove SonarCloud's dependency on test job #1095

Merged
merged 10 commits into from
May 10, 2024

Conversation

danlu1
Copy link
Contributor

@danlu1 danlu1 commented May 10, 2024

Problem:
Currently, sonarcloud only executes when tests pass, but even if tests fail, it's valuable for sonarcloud to execute.

Solution:
Let SonarCloud scan always run no matter what status of the previous steps. Add a separate step to check if coverage report exist, if not, skip downloading coverage report. Run Override Coverage Source Path for Sonar, only if the coverage report download step has succeeded.

Testing:

  1. Skip downloading the coverage report when the coverage report does not exist
  2. The SonarCloud scan runs even though Override Coverage Source Path for Sonar fails.
Screenshot 2024-05-09 at 8 45 42 PM 3. Skip Override Coverage Source Path for Sonar when the coverage report does not exist. Screenshot 2024-05-10 at 9 08 14 AM

@danlu1 danlu1 requested a review from a team as a code owner May 10, 2024 00:28
Co-authored-by: BryanFauble <17128019+BryanFauble@users.noreply.github.com>
Copy link
Contributor

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danlu1 danlu1 merged commit 5d43e18 into develop May 10, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants