-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYNPY-1341] Add CI step to containerize and upload synpy to the GHCR #1100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work!
This PR is now ready for a final review. Latest changes:
Feedback is welcome. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me! We can test this out and adjust based on feedback.
Great thanks @BryanFauble - Once all tests pass I'll squash and merge this. |
problem
We recently added a GHCR image for the python client because there was no up-to-date image hosted anywhere. We should add a step to the CI workflow to publish new versions of the client as docker images automatically when a new version is released.
solution
Two new jobs (
ghcr-build-and-push-on-merge
,ghcr-build-and-push-on-develop
) are created to build a multi-platform image of the repository and push it to the GitHub Container Registry.ghcr-build-and-push-on-release
- [ ] The docker image should be multi-platform (AMD64, ARM64)ghcr-build-and-push-on-develop
develop
(i.e. PR merges)- [ ] The docker image should be multi-platform (AMD64, ARM64)develop
testing & preview
ghcr-build-and-push-on-release
I manually fed a version
v1.2.3test
that will be fed into theBuild and push Docker image
step to test that this communication happens betweenExtract Release Version
andBuild and push Docker image
.Triggering the job results in a new release with the expected version name
I pulled the docker image and ran a container to confirm that the latest version
v4.2.0
of the python client is running in the container:ghcr-build-and-push-on-develop
develop
image tag name reflects the latest commit it points to. Below is the example for commit 8303999 of this branch: