-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYNPY-1384] Create uploading data in bulk tutorial #1101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I followed along and went through the updated docs and everything looks good and worked as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Thanks for the review and work! Just tiny comment.
|
||
print(f"Batch 1 Folder ID: {batch_1_folder_id}") | ||
|
||
{!docs/tutorials/python/tutorial_scripts/annotation.py!lines=5-22} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is neat, although does this put a risk on making sure we don't notify these tutorial_scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree there is some risk here. My opinion is its a risk by manually copying the code over. At least in this way the code gets updated and the lines for each step is updated. I guess it'll be something to look out for in future PRs if there are changes.
Co-authored-by: Brad Macdonald <52762200+BWMac@users.noreply.github.com>
Problem:
Solution:
Testing: