SYNPY-714 #548
Merged
SYNPY-714 #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimyen
commented
May 25, 2018
| raise ValueError("Values of type %s is not yet supported." % type(values)) | ||
| if not pandas_available: | ||
| raise ValueError("pandas package is required.") | ||
| cols = as_table_columns(values) | ||
| schema = Schema(name=name, columns=cols, parent=parent) | ||
| return Table(schema, values) | ||
| headers = [SelectColumn.from_column(col) for col in cols] |
There was a problem hiding this comment.
Per @zimingd, we should refactor the name of SelectColumn to something else that represents what the class is: type information for each column of the CSV file. SelectColumn used to be used for only for CSVs retrieved from synapse; in that case, SelectColumn represented the types of columns that were in the SQL SELECT clause (including aggregates).
kimyen
commented
May 25, 2018
tests/unit/unit_test_tables.py
Outdated
| table = build_table("test", "syn123", "some_file_name") | ||
| assert len(table) == 3 | ||
| for col, row in enumerate(table): | ||
| assert row[0] == (col + 1) |
There was a problem hiding this comment.
use assert_equals instead because assert does not show the different between the 2 values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.