Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg_resources is a deprecated API - replace with importlib.resources #975

Merged
merged 14 commits into from Jul 2, 2023
Merged

pkg_resources is a deprecated API - replace with importlib.resources #975

merged 14 commits into from Jul 2, 2023

Conversation

thomasyu888
Copy link
Member

Replace pkg_resources call with importlib.resources

@thomasyu888 thomasyu888 marked this pull request as ready for review June 26, 2023 21:53
@thomasyu888 thomasyu888 requested a review from a team as a code owner June 26, 2023 21:53
vpchung
vpchung approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@vpchung vpchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! This should help fix an import issue on one of our collab's end too.

@thomasyu888 thomasyu888 merged commit 669c4c9 into Sage-Bionetworks:develop Jul 2, 2023
19 checks passed
@thomasyu888 thomasyu888 deleted the dont-use-pkg-resources branch July 2, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpchung vpchung vpchung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thomasyu888 @vpchung