Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYNPY-1296] Config client error with api key or PAT #990

Merged
merged 3 commits into from
Oct 20, 2023
Merged

[SYNPY-1296] Config client error with api key or PAT #990

merged 3 commits into from
Oct 20, 2023

Conversation

BryanFauble
Copy link
Contributor

Problem:
The username is getting passed around in some cases as blank instead of None.

Solution:
Do a None and blank check on the username

Testing:
Tested using the CLI synapse login:
image

Tested with the CLI synapse config and verified I could do a synapse login after:
image

@BryanFauble BryanFauble requested a review from a team as a code owner October 20, 2023 20:19
thomasyu888
thomasyu888 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 thanks for the quick fix!

@BryanFauble BryanFauble merged commit 4f7cf52 into develop Oct 20, 2023
33 of 35 checks passed
@BryanFauble BryanFauble deleted the synpy-1296-config-client-error branch October 30, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasyu888 thomasyu888 thomasyu888 approved these changes

@BWMac BWMac Awaiting requested review from BWMac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BryanFauble @thomasyu888