Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYNPY-1298] flakey integration tests #999

Merged
merged 52 commits into from
Oct 30, 2023
Merged

Conversation

BryanFauble
Copy link
Contributor

Problem:
Several unit tests are very flaky, or timeout after 6 hours.

Solution:
Introduced 2 new packages:

    pytest-rerunfailures~=12.0
    func-timeout~=4.3
  1. The func-timeout is to time bound some calls
  2. The rerunfailures allows us to add a decorator to tests and conditionally re-run them a number of time (It's rare for them to fail multiple times in a row)

Testing:

  1. See latest pipeline: https://github.com/Sage-Bionetworks/synapsePythonClient/actions/runs/6681317916 - Note: The pipeline in the PR might fail because of newly introduced dependencies that might not be in the cached dependencies

@BryanFauble BryanFauble requested a review from a team as a code owner October 30, 2023 19:15
@pep8speaks
Copy link

pep8speaks commented Oct 30, 2023

Hello @BryanFauble! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 144:89: E501 line too long (113 > 88 characters)
Line 165:89: E501 line too long (111 > 88 characters)
Line 182:89: E501 line too long (121 > 88 characters)
Line 199:89: E501 line too long (143 > 88 characters)
Line 219:89: E501 line too long (99 > 88 characters)
Line 226:89: E501 line too long (99 > 88 characters)

Line 14:1: F401 'synapseclient' imported but unused

Line 39:89: E501 line too long (99 > 88 characters)

Line 355:89: E501 line too long (99 > 88 characters)

Line 21:89: E501 line too long (99 > 88 characters)

Comment last updated at 2023-10-30 20:36:53 UTC

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I added some comments.

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 LGTM! @BWMac if you wanted to review for for cross training, that'd be great, but it doesn't block the merging of this ticket.

@BryanFauble BryanFauble merged commit 831c2a5 into develop Oct 30, 2023
27 of 32 checks passed
@BryanFauble BryanFauble deleted the SYNPY-1298-flakey-tests branch October 30, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants