Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiActionButton dropdown is aligned to the right side of the button #6705

Closed
1 task done
nick-khaustov-sage opened this issue Apr 30, 2024 · 3 comments · Fixed by #6726
Closed
1 task done

MultiActionButton dropdown is aligned to the right side of the button #6705

nick-khaustov-sage opened this issue Apr 30, 2024 · 3 comments · Fixed by #6726

Comments

@nick-khaustov-sage
Copy link

Description

When the dropdown is wider than the button itself, it is aligned to the right side of the button while the DS aligns to the left (it is also more natural). Note that align property of the component has no effect on that.

From the discussion:
"i'd recommend using left aligned (minor button example in your screenshot) for path to completion and legibility reasons. Only when there's not enough space (right side of screen) should we align right."

image

Reproduction

https://stackblitz.com/edit/parsium-carbon-starter-msdduz?file=src%2FApp.tsx

Steps to reproduce

No response

JIRA ticket numbers (Sage only)

No response

Suggested solution

No response

Carbon version

133.0.5

Design tokens version

No response

Relevant browsers

Chrome

Relevant OSs

MacOS

Additional context

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@nick-khaustov-sage nick-khaustov-sage added Bug triage Triage Required labels Apr 30, 2024
@harpalsingh
Copy link
Member

Just to add if left aligned is default, we should still add an option to right align if the design requires it (outside of auto position based on screen)

@Parsium
Copy link
Contributor

Parsium commented Apr 30, 2024

FE-6538

@Parsium Parsium added On Backlog and removed triage Triage Required labels Apr 30, 2024
nuria1110 added a commit that referenced this issue May 7, 2024
Add a position prop to allow consumers to specify on which side the menu is aligned to when opened.

fix #6705
nuria1110 added a commit that referenced this issue May 7, 2024
Adds position prop to allow consumers to specify on which side the menu is aligned to when opened.

fix #6705
nuria1110 added a commit that referenced this issue May 8, 2024
Adds position prop to allow consumers to specify on which side the menu is aligned to when opened.

fix #6705
nuria1110 added a commit that referenced this issue May 8, 2024
Adds position prop to allow consumers to specify on which side the menu is aligned to when opened.

fix #6705
nuria1110 added a commit that referenced this issue May 13, 2024
Adds position prop to allow consumers to specify on which side the menu is aligned to when opened.

fix #6705
nuria1110 added a commit that referenced this issue May 13, 2024
Adds position prop to allow consumers to specify on which side the menu is aligned to when opened.

fix #6705
nuria1110 added a commit that referenced this issue May 13, 2024
Adds position prop to allow consumers to specify on which side the menu is aligned to when opened.

fix #6705
nuria1110 added a commit that referenced this issue May 14, 2024
Adds position prop to allow consumers to specify on which side the menu is aligned to when opened.

fix #6705
nuria1110 added a commit that referenced this issue May 16, 2024
Adds position prop to allow consumers to specify on which side the menu is aligned to when opened.

fix #6705
carbonci pushed a commit that referenced this issue May 16, 2024
## [135.1.0](v135.0.0...v135.1.0) (2024-05-16)

### Features

* **multi-action-button:** add position prop ([0a152b5](0a152b5)), closes [#6705](#6705)
* **split-button:** add position prop ([716bed3](716bed3))
@carbonci
Copy link
Collaborator

🎉 This issue has been resolved in version 135.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants