Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grid): add responsive grid component #2668

Merged
merged 5 commits into from
Mar 18, 2020
Merged

Conversation

ian-forster
Copy link
Contributor

@ian-forster ian-forster commented Feb 24, 2020

Proposed behaviour

This Grid Component delivers the responsive grid as specified in the RFC

Current behaviour

Before this component was added Carbon did not provide a responsive layout component.

Checklist

  • Release notes (Conventional Commits)
  • Unit tests
  • Cypress automation tests
  • Storybook added or updated
  • Theme support - Not applicable to Grid as there are no theme styles
  • Typescript d.ts file added or updated

Testing instructions

Follow the instructions in the mdx file to see how the Grid behaves at different given widths.

damianOfKyan
damianOfKyan previously approved these changes Feb 27, 2020
src/components/grid/grid-item/grid-item.component.js Outdated Show resolved Hide resolved
src/components/grid/grid.stories.mdx Outdated Show resolved Hide resolved
src/components/grid/grid-item/grid-item.component.js Outdated Show resolved Hide resolved
damianOfKyan
damianOfKyan previously approved these changes Mar 3, 2020
jamime
jamime previously approved these changes Mar 3, 2020
damianOfKyan
damianOfKyan previously approved these changes Mar 9, 2020
KatarzynaQA
KatarzynaQA previously approved these changes Mar 16, 2020
damianOfKyan
damianOfKyan previously approved these changes Mar 16, 2020
@ian-forster ian-forster merged commit b6882e6 into master Mar 18, 2020
@ian-forster ian-forster deleted the FE-1650-responsive-grid branch March 18, 2020 09:54
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 14.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

7 participants