Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multi-user service not working with packet #6

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix multi-user service not working with packet #6

wants to merge 1 commit into from

Conversation

wwqgtxx
Copy link
Contributor

@wwqgtxx wwqgtxx commented Aug 16, 2023

fix #5

@Yuzuki616
Copy link

Yuzuki616 commented Aug 16, 2023 •
edited
Loading

decrypted或许在continue之前切一下片重置一下len会更好？不重置len的话或许会重新分配底层数组导致潜在的性能损失
Screenshot_20230816_084922

我只看了gcm的实现，不清楚其他的是不是也有类似逻辑

@wwqgtxx
Copy link
Contributor Author

wwqgtxx commented Aug 16, 2023

@Yuzuki616 他这里校验的是cap，不会导致重分配底层数组的

@Yuzuki616
Copy link

但是total是根据dst的len计算的吧

@wwqgtxx
Copy link
Contributor Author

wwqgtxx commented Aug 16, 2023

但是total是根据dst的len计算的吧

dst传入的始终是len为0的原slice

@Yuzuki616
Copy link

Yuzuki616 commented Aug 16, 2023 •
edited
Loading

ok，是我的理解出了问题，因为我昨天在修复的时候让dst和返回值共用了同一个变量，不好意思，感谢您的修复。

@dyhkwong
Copy link

dyhkwong commented Jan 8, 2024

Any progress?

@dyhkwong dyhkwong mentioned this pull request Jun 16, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shadowsocks_multi存在用户验证bug
3 participants
@wwqgtxx @Yuzuki616 @dyhkwong