Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File send nicities #2395

Open
umairkhannn opened this issue Mar 14, 2024 · 3 comments
Open

File send nicities #2395

umairkhannn opened this issue Mar 14, 2024 · 3 comments
Assignees

Comments

@umairkhannn
Copy link
Member

https://saito.io/redsquare?tweet_id=6ab9bd6923bef0690e37805e278aeeaed23951e6635129272aa33df29d8ef038464f1ed34bee2f29d80979ed240d2ec6fcd653d03099c6e0dec14e7c54bac39a

Regarding the file transfer feature, I think it could be nice to have the following:

  • an indication of the file size in the progress percentage modal
  • an indication of the current transfer speed in the progress percentage modal
  • a browser window prompt specifying that the transfer will fail if leaving the current tab
@umairkhannn umairkhannn self-assigned this Mar 14, 2024
@umairkhannn
Copy link
Member Author

umairkhannn commented Mar 20, 2024

File transfer speed and size of file that is transferred added:

Screenshot from 2024-03-20 11-38-48
Screenshot from 2024-03-20 11-39-01

@umairkhannn
Copy link
Member Author

umairkhannn commented Mar 20, 2024

  • Showing prompt when closing tab while file transfer is in progress: image

  • Web browsers doesnt allow us to modify default prompt message of 'beforeunload' event due to security concerns: Screenshot from 2024-03-20 12-38-31

@umairkhannn
Copy link
Member Author

umairkhannn commented Mar 20, 2024

Also fixed an issue (not mentioned here) where the d file size, inside chat, was not showing decimal places.
File size: 8.39 MB
Inside chat: 8.00 MB

Issue:
Screenshot from 2024-03-20 11-17-16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant