In-game crypto offfer validation #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
umairkhannn
commented
Apr 14, 2024
umairkhannn
commented
- you cannot enter negative numbers
- you cannot enter letters emoji etc
- that the numbers entered are sane (not more than 8 significant figures before or after the decimal.
- Make the 'Confirm P2P gaming is legal in my jurisdiction option is checked by default.
This was
linked to
issues
Apr 14, 2024
|
Validation should match the send ui. The rules should be enforced on what can be entered into the input... Right now it is possible to enter non-alpha chars including We should not be validating this with a confirmation. Similarly it should not be possible to enter more than 10 decimal places or numbers bigger than the max stake available to anyone in the game.
|
|
This is looking good though I can still enter Fix that and this is complete. |
Okay got it. |
joelshu1
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Validate in-game stake amount * checkbox checked by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.