New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added icc profile routines #208
Conversation
The first img (0047.jpg) would still change color when using default values, for example (To be honest, it's really hard to distinguish whether the color has changed, and I even believe that the color change in the image is caused by the encoding of the mozjpeg itself.) (build with gnu target on windows10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When input a bmp pic which has a icc tag and output with other codec, rimge output it with wrong color.
I suppose that it because I apply ICC profile to srbg profile, so some colors can be loss. I will create another issue to add
This is issue in |
Will this be fixed or just mark as a note in readme, or maybe we'd better make an issue in Here ?
This option is for all supported codecs (include input only codec) or just the formats that allow both input and output? And, some codecs doesn't support icc feature such as qoi etc. |
Create an Issue in zune-image
If input image has ICC profile and output codec supports writing ICC profile this option will preserve this as a tag in metadata. Otherwise will transform image to srgb profile or does nothing if image doesn't have ICC profile. |
@SalOne22 icc feature in zune-bmp has been fixed. |
Okay, while we waiting for new release of zune-image, we can merge this now, and create a new pre-release with partial icc support. This will allow usage of new features, and after new zune-image version add support for bmp files (I don't think that most of the users will face this issue, most of the images on the web are in jpg/png format) |
ok, and I'll approve this and start to work on the better-docs branch. |
@Mikachu2333 this PR adds support for images with icc profile. Could you check that everything work as expected now?
closes #138