Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception policy for handling request, notification and message. #21

Closed
veblush opened this issue May 18, 2016 · 0 comments
Closed

Exception policy for handling request, notification and message. #21

veblush opened this issue May 18, 2016 · 0 comments
Assignees

Comments

@veblush
Copy link
Contributor

veblush commented May 18, 2016

Current state of exception handling is:

  • When handling a request, forward exception to requester and go on.
  • When handling a notification and a message, follow akka exception policy (ask a parent to what to do)

The reason that request handling have a different exception policy is that it follows the RPC model and exception need to be propagated to caller. (not parent) But this inconsistency is not good to keep and sometimes a critical exception in handling a request requires parent to do something. It seems reasonable to change policy like following.

  • When handlig a [request | notification | message], follow akka exception policy.
  • There might be an option to make some kinds of exception propagated to a caller not a parent.
  • Whenever an exception is raised in handling a request, a caller should get exception response to prevent a request timeout.
veblush added a commit that referenced this issue May 20, 2016
@veblush veblush self-assigned this May 20, 2016
veblush added a commit that referenced this issue May 22, 2016
@veblush veblush closed this as completed May 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant