Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AddressesForServices to export package method #75

Merged
merged 4 commits into from
Jan 18, 2023

Conversation

jirik1h
Copy link

@jirik1h jirik1h commented Jan 17, 2023

@Salamek
Copy link
Owner

Salamek commented Jan 17, 2023

@jirik1h looks great! Just one thing, are fixes in bbf3f94 tested against ppl API? (PplMyApi doc are sometimes incorrect and it feels weird to me that this wrong implementation lived in the code for so long without anyone noticing)

@jirik1h
Copy link
Author

jirik1h commented Jan 17, 2023

Yes i have tested it. Original version allways fail with response, that code is unknown and soap generated just empty tag for external numbers. Now it is working and we allready using it in production and everything is good.

@Salamek Salamek merged commit 3f433f8 into Salamek:master Jan 18, 2023
@Salamek
Copy link
Owner

Salamek commented Jan 18, 2023

Released in 2.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants