feat: support some JSON array endpoints #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some endpoints return JSON arrays instead of objects. This adds support for two such ones, and related sniffing where proper Content-Type isn't available.
The casts here are not nice at all, but going all the way with fixing the type hints to accommodate this would result in the need to add lots of them all over the codebase. And because some of the lower level return type hints are incorrect already, adding these bits doesn't seem that gross.
(No need for a release for this either yet, as far as I'm concerned, I have still some other bits pending.)