Bug fix: MultiOutSizeLinear masks outputs to 0 when dimension of parameter >1 and dim * patch_size is not present in out_feat_size. #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a major bug for the
MultiOutSizeLinear
class.When
dim > 1
in the following code snippet,uni2ts/src/uni2ts/distribution/_base.py
Lines 74 to 85 in c4d75a3
it causes
for feat_size in self.out_features_ls
bedim * patch_size
, whereasout_feat_size
contains the patch sizes. This means that certain patch sizes could be ignored.uni2ts/src/uni2ts/module/ts_embed.py
Lines 172 to 178 in c4d75a3
For the current configuration, this means that outputs with patch sizes 8 and 16 are always masked to 0.
Closes #44