New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrap password in cdata to avoid XML encoding errors #141

Merged

jbachelet merged 1 commit into SalesforceCommerceCloud:develop from sfdc-qbranch:bugfix/xml-encoding-issue

Mar 28, 2022

Contributor

clavery commented Mar 15, 2022

It's not uncommon for the client secret to contain invalid XML chars (for instance '&' or '<'). This results in an ugly error and failed deploy.

CDATA in this element ensures the interpolated values are treated as character data and not XML.


          wrap password in cdata to avoid XML encoding errors

cf983b9

Contributor

jbachelet commented Mar 28, 2022

Thank you for your PR, awesome!

jbachelet merged commit d6c81c5 into SalesforceCommerceCloud:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment