Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Fix for 1 vulnerabilities #172

Closed
wants to merge 4 commits into from

Conversation

snyk-bot
Copy link
Contributor

@snyk-bot snyk-bot commented May 1, 2020

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

As this is a private repository, Snyk-bot does not have access. Therefore, this PR has been created automatically, but appears to have been created by a real user.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • packages/generator/package.json
    • packages/generator/package-lock.json
    • packages/generator/.snyk

Vulnerabilities that will be fixed

With a Snyk patch:
Severity Issue Exploit Maturity
medium severity Prototype Pollution
SNYK-JS-LODASH-567746
Proof of Concept

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:

🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic

….json & packages/generator/.snyk to reduce vulnerabilities

The following vulnerabilities are fixed with a Snyk patch:
- https://snyk.io/vuln/SNYK-JS-LODASH-567746
….json & packages/generator/.snyk to reduce vulnerabilities

The following vulnerabilities are fixed with a Snyk patch:
- https://snyk.io/vuln/SNYK-JS-LODASH-567746
….json & packages/generator/.snyk to reduce vulnerabilities

The following vulnerabilities are fixed with a Snyk patch:
- https://snyk.io/vuln/SNYK-JS-LODASH-567746
@snyk-bot snyk-bot requested a review from a team as a code owner May 1, 2020 08:37
@wjhsf
Copy link
Contributor

wjhsf commented May 4, 2020

This PR sets snyk protect as the package's prepare script (tl;dr runs after npm install) and adds a .snyk policy file so the script will work. Included in the policy file is the config required to patch the linked vulnerability.

Where possible, snyk protect bumps package versions to fix vulnerabilities (like npm audit fix). If a new, fixed version of a package isn't available, snyk protect patches the vulnerability directly in your local node_modules directory. For more info: https://support.snyk.io/hc/en-us/articles/360003891078-Snyk-patches-to-fix-vulnerabilities

The vulnerability patched here is an issue with _.zipObjectDeep, a function that is not used in this project. There is no updated version of the package to upgrade to, so snyk provides the patch.

Snyk does not currently have 3PP approval, but there is a pending request.

@wjhsf wjhsf mentioned this pull request May 7, 2020
@wjhsf
Copy link
Contributor

wjhsf commented May 7, 2020

Closing in favor of #179.

@wjhsf wjhsf closed this May 7, 2020
@wjhsf wjhsf deleted the snyk-fix-f267d7b74c6e46b3935dee974b51e28d branch May 7, 2020 14:23
wjhsf added a commit that referenced this pull request May 11, 2020
* Replay snyk changes.

* Remove duplicate loglevel; alphabetize snyk.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants