-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v3.0.0 - @W-15675100@ #403
Conversation
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we listing all the public changes mentioned in the PR description?
Example:
SLAS admin
1.12.17 --> 1.12.18
Addition of property useWellKnown to response
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I've only added changes about the addition/removal of any endpoints. The summary above was meant as an aid for reviewing since there are a large amount of changes
@joeluong-sfcc looks like the Custom API support is not merged yet: #402 That PR should be merged first, right? |
@vmarta Yes, that's correct. Once that gets merged into main, I'll merge those changes into this PR and resolve any conflicts |
@@ -1,40 +0,0 @@ | |||
import { ShopperToken, stripBearer, ResponseError, getObjectFromResponse } from "@commerce-apps/core" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this helper function for retrieving an access token using the deprecated Shopper Customers authorizeCustomer
endpoint. Now that the endpoint is removed, we can remove this helper function. This shouldn't be breaking as this is no longer supported by the API and all customers have migrated to SLAS
c_validCustomParam: "custom_param", | ||
}) | ||
.reply(200, MOCK_RESPONSE); | ||
|
||
const response = await customersClient.authorizeCustomer(options); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had to update this unit test to use another endpoint as this deprecated endpoint is now removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR Releases
v2.16.0
of thecommerce-sdk
. Changes include:This PR also pulls in the latest versions of all the RAMLs, and this was done by modifying RAML toolkit to pull in the latest version instead of the production instance version: https://github.com/SalesforceCommerceCloud/raml-toolkit/pull/223/files
Some headers were removed on certain endpoints such as:
But since the SDKs don't consider the headers when generating typescript, these changes can be ignored
API changes
Shopper Baskets2.0.3 --> 2.0.7guestOrderLookup
endpoint addedCustomerGroupRule
,CustomerGroup
, andCustomerGroupSearchResult
types addedsearchCustomerGroup
endpoint addeduseWellKnown
to responseredeemCoupon
endpoint addedcount
renamed tolimit
on response objectnone
enum added toexpand
query parameter