Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] User stuck on confirmation modal when signing out on checkout #1142

Closed
breadadams opened this issue Apr 18, 2023 · 5 comments · Fixed by #1172
Closed

[BUG] User stuck on confirmation modal when signing out on checkout #1142

breadadams opened this issue Apr 18, 2023 · 5 comments · Fixed by #1172
Labels
Acknowledged Team has responded to issue

Comments

@breadadams
Copy link
Contributor

Summary

When checking out as a logged-in user, if I click the "Sign Out" button I end up stuck on the confirmation modal.

Steps To Reproduce

  1. Sign in to an account, add products to basket.
  2. Navigate to the checkout, click "Sign Out" in the Contact Info section.
  3. Click the red "Sign Out" button in the confirmation modal.

Expected result

User should be redirected somewhere (?)

Actual result

The sign out confirmation modal remains visible.

System Information (as applicable)

Browser: Chrome
Node version: 14
pwa-kit version: 2.7.0
Desktop OS: macOS
Mobile Device Info:

Additional information

pwa-kit-checkout-sign-out-bug.mov
@bfeister bfeister added the Acknowledged Team has responded to issue label Apr 19, 2023
@bfeister
Copy link
Collaborator

on the demo site right now https://pwa-kit.mobify-storefront.com/, I'm not able to reproduce this because I can't add items to the basket per your issue reported at

#1141

@breadadams
Copy link
Contributor Author

@bfeister it should be reproducible, I was able to on the demo site just yesterday. It doesn't depend on #1141 as in this case you add the items to your basket after signing in (not after registering).

@bfeister
Copy link
Collaborator

@breadadams thanks for the context! Apologize that I'm a bit distracted today and trying to look at this in spare moments between meetings. But yes, I get it now. I'll log out, log back in with that user / refresh and then go try to add items. Will follow up

@bfeister
Copy link
Collaborator

@breadadams thanks, was able to reproduce now. 👍

@bfeister
Copy link
Collaborator

Given this following request

curl 'https://pwa-kit.mobify-storefront.com/mobify/proxy/api/customer/shopper-customers/v1/organizations/f_ecom_zzrf_001/customers/bckrwXxug2xbsRxbaUwGYYmuoU/baskets?siteId=RefArchGlobal' \
  -H 'authority: pwa-kit.mobify-storefront.com' \
  -H 'accept: */*' \
  -H 'accept-language: en-US,en;q=0.9' \
  -H 'authorization: Bearer <jwt token> \
  -H 'cache-control: no-cache' \
  -H 'pragma: no-cache' \
  -H 'sec-ch-ua: "Chromium";v="112", "Google Chrome";v="112", "Not:A-Brand";v="99"' \
  -H 'sec-ch-ua-mobile: ?0' \
  -H 'sec-ch-ua-platform: "macOS"' \
  -H 'sec-fetch-dest: empty' \
  -H 'sec-fetch-mode: cors' \
  -H 'sec-fetch-site: same-origin' \
  -H 'user-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.0.0 Safari/537.36' \
  --compressed

I get the following 400 error back

{
"title": "Invalid Customer",
"type": "https://api.commercecloud.salesforce.com/documentation/error/v1/errors/invalid-customer",
"detail": "The customer is invalid."
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Acknowledged Team has responded to issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants