Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to React 18 #1166

Merged
merged 55 commits into from
May 15, 2023
Merged

Upgrade to React 18 #1166

merged 55 commits into from
May 15, 2023

Commits on May 2, 2023

  1. upgrade to React 18

    @alexvuong
    alexvuong committed May 2, 2023
    Configuration menu
    Copy the full SHA
    43be7eb View commit details
    Browse the repository at this point in the history

  2. fix styling and hydration error

    @alexvuong
    alexvuong committed May 2, 2023
    Configuration menu
    Copy the full SHA
    05157af View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. fix hydration error

    @alexvuong
    alexvuong committed May 3, 2023
    Configuration menu
    Copy the full SHA
    8ee458a View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. clean up

    @alexvuong
    alexvuong committed May 4, 2023
    Configuration menu
    Copy the full SHA
    09890a1 View commit details
    Browse the repository at this point in the history

  2. fix forms

    @alexvuong
    alexvuong committed May 4, 2023
    Configuration menu
    Copy the full SHA
    0f246b4 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. fix comment

    @alexvuong
    alexvuong committed May 5, 2023
    Configuration menu
    Copy the full SHA
    2530ac7 View commit details
    Browse the repository at this point in the history

  2. minor fix

    @alexvuong
    alexvuong committed May 5, 2023
    Configuration menu
    Copy the full SHA
    08b7f8c View commit details
    Browse the repository at this point in the history

  3. fix hydration error

    @alexvuong
    alexvuong committed May 5, 2023
    Configuration menu
    Copy the full SHA
    9967e42 View commit details
    Browse the repository at this point in the history

  4. fix form, and bump testing-library/user-event

    @alexvuong
    alexvuong committed May 5, 2023
    Configuration menu
    Copy the full SHA
    6c5df47 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'v3' into upgrade-react-18

    @alexvuong
    alexvuong committed May 5, 2023
    Configuration menu
    Copy the full SHA
    69f50de View commit details
    Browse the repository at this point in the history

  6. linting

    @alexvuong
    alexvuong committed May 5, 2023
    Configuration menu
    Copy the full SHA
    127f52e View commit details
    Browse the repository at this point in the history

Commits on May 6, 2023

  1. remove unused packages

    @alexvuong
    alexvuong committed May 6, 2023
    Configuration menu
    Copy the full SHA
    19cf108 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. clean up

    @alexvuong
    alexvuong committed May 8, 2023
    Configuration menu
    Copy the full SHA
    980582e View commit details
    Browse the repository at this point in the history

  2. fix tests

    @alexvuong
    alexvuong committed May 8, 2023
    Configuration menu
    Copy the full SHA
    e9fb9b5 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. fix tests

    @alexvuong
    alexvuong committed May 9, 2023
    Configuration menu
    Copy the full SHA
    98ecdc8 View commit details
    Browse the repository at this point in the history

  2. fix ts

    @alexvuong
    alexvuong committed May 9, 2023
    Configuration menu
    Copy the full SHA
    764f52f View commit details
    Browse the repository at this point in the history

  3. regenerate lock files

    @alexvuong
    alexvuong committed May 9, 2023
    Configuration menu
    Copy the full SHA
    2417f95 View commit details
    Browse the repository at this point in the history

  4. clean up

    @alexvuong
    alexvuong committed May 9, 2023
    Configuration menu
    Copy the full SHA
    29ab6ad View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. fix tests, and enforce npm 8

    @alexvuong
    alexvuong committed May 10, 2023
    Configuration menu
    Copy the full SHA
    a9b6787 View commit details
    Browse the repository at this point in the history

  2. fix tests

    @alexvuong
    alexvuong committed May 10, 2023
    Configuration menu
    Copy the full SHA
    ee23020 View commit details
    Browse the repository at this point in the history

  3. fix tests

    @alexvuong
    alexvuong committed May 10, 2023
    Configuration menu
    Copy the full SHA
    75a4050 View commit details
    Browse the repository at this point in the history

  4. update engines to npm 8

    @alexvuong
    alexvuong committed May 10, 2023
    Configuration menu
    Copy the full SHA
    3a1bb2e View commit details
    Browse the repository at this point in the history

  5. drop 7 on CI

    @alexvuong
    alexvuong committed May 10, 2023
    Configuration menu
    Copy the full SHA
    2a09e1a View commit details
    Browse the repository at this point in the history

  6. minor fix

    @alexvuong
    alexvuong committed May 10, 2023
    Configuration menu
    Copy the full SHA
    44cba91 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'v3' into upgrade-react-18

    @alexvuong
    alexvuong committed May 10, 2023
    Configuration menu
    Copy the full SHA
    ec2dae3 View commit details
    Browse the repository at this point in the history

  8. fiz tests, drop npm 7

    @alexvuong
    alexvuong committed May 10, 2023
    Configuration menu
    Copy the full SHA
    ecd0283 View commit details
    Browse the repository at this point in the history

  9. clean up

    @alexvuong
    alexvuong committed May 10, 2023
    Configuration menu
    Copy the full SHA
    dc66133 View commit details
    Browse the repository at this point in the history

  10. fix tests

    @alexvuong
    alexvuong committed May 10, 2023
    Configuration menu
    Copy the full SHA
    c466ce6 View commit details
    Browse the repository at this point in the history

  11. PR feedback

    @alexvuong
    alexvuong committed May 10, 2023
    Configuration menu
    Copy the full SHA
    17c12d8 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'v3' into upgrade-react-18

    @alexvuong
    alexvuong committed May 10, 2023
    Configuration menu
    Copy the full SHA
    0839ff4 View commit details
    Browse the repository at this point in the history

  13. gen lock file again

    @alexvuong
    alexvuong committed May 10, 2023
    Configuration menu
    Copy the full SHA
    18c8794 View commit details
    Browse the repository at this point in the history

  14. drop npm7 in CI for windows

    @alexvuong
    alexvuong committed May 10, 2023
    Configuration menu
    Copy the full SHA
    bd4881d View commit details
    Browse the repository at this point in the history

  15. minor fix

    @alexvuong
    alexvuong committed May 10, 2023
    Configuration menu
    Copy the full SHA
    9eb5ff9 View commit details
    Browse the repository at this point in the history

  16. regen lock file again!

    @alexvuong
    alexvuong committed May 10, 2023
    Configuration menu
    Copy the full SHA
    668b8eb View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. minor fix

    @alexvuong
    alexvuong committed May 11, 2023
    Configuration menu
    Copy the full SHA
    731e40c View commit details
    Browse the repository at this point in the history

  2. lint

    @alexvuong
    alexvuong committed May 11, 2023
    Configuration menu
    Copy the full SHA
    209a8a0 View commit details
    Browse the repository at this point in the history

  3. swap element order to avoid hydration error

    @alexvuong
    alexvuong committed May 11, 2023
    Configuration menu
    Copy the full SHA
    6f8564d View commit details
    Browse the repository at this point in the history

  4. do user setup in renderWithProviders

    @alexvuong
    alexvuong committed May 11, 2023
    Configuration menu
    Copy the full SHA
    5616bea View commit details
    Browse the repository at this point in the history

  5. Footer: remove isHydrated call

    @vmarta
    vmarta committed May 11, 2023
    Configuration menu
    Copy the full SHA
    29c6b1d View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. update lock files

    @alexvuong
    alexvuong committed May 12, 2023
    Configuration menu
    Copy the full SHA
    a6109af View commit details
    Browse the repository at this point in the history

  2. fix: update commerce-sdk-react unit tests to work with react 18 (#1184) 

    * fix most unit tests

* stablize commerce-sdk-react tests

* add link

* fix typo

* remove TODOs

* lint

* remove additional TODO

* update changelog

* address PR comments

---------

Co-authored-by: Kevin He <kevin.he@salesforce.com>
Co-authored-by: Alex Vuong <alex.vuong@salesforce.com>
    @joeluong-sfcc @kevinxh @alexvuong
    3 people committed May 12, 2023
    Configuration menu
    Copy the full SHA
    b914667 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into upgrade-react-18

    @alexvuong
    alexvuong committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c6532ad View commit details
    Browse the repository at this point in the history

  4. update from new develop and gen lock files

    @alexvuong
    alexvuong committed May 12, 2023
    Configuration menu
    Copy the full SHA
    0c7e541 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. update React in test project

    @alexvuong
    alexvuong committed May 15, 2023
    Configuration menu
    Copy the full SHA
    d5e4b4b View commit details
    Browse the repository at this point in the history

  2. update React in test project

    @alexvuong
    alexvuong committed May 15, 2023
    Configuration menu
    Copy the full SHA
    673860e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into upgrade-react-18

    @alexvuong
    alexvuong committed May 15, 2023
    Configuration menu
    Copy the full SHA
    2f4862e View commit details
    Browse the repository at this point in the history

  4. needs to use override for nwsapi in Retail app

    @alexvuong
    alexvuong committed May 15, 2023
    Configuration menu
    Copy the full SHA
    32c7c0f View commit details
    Browse the repository at this point in the history

  5. update lock files

    @alexvuong
    alexvuong committed May 15, 2023
    Configuration menu
    Copy the full SHA
    4b4667f View commit details
    Browse the repository at this point in the history

  6. Replace enzyme (#1201) 

    * replace enzyme with testing library

* fix tests

* fix tests and add TODOs

* fix tests

* update browser test

* fix tests

* lint code

* partially update app-error-boundary tests

* fix some tests

* regen lock files

* fix route-component tests

* remove test that tests implementation detail

* update tests for throw-404

* clean up

* clean up

* update app-error-boundary test

* lint code

* remove container from document test

* remove debug

* lint code

* update focus test

* linting

* update lock files

---------

Co-authored-by: Joel Uong <joel.uong@salesforce.com>
Co-authored-by: Joel Uong <88680517+joeluong-sfcc@users.noreply.github.com>
    @alexvuong @joeluong-sfcc
    3 people committed May 15, 2023
    Configuration menu
    Copy the full SHA
    b18c75c View commit details
    Browse the repository at this point in the history

  7. address feedback

    @alexvuong
    alexvuong committed May 15, 2023
    Configuration menu
    Copy the full SHA
    2f69f6a View commit details
    Browse the repository at this point in the history

  8. clean up

    @alexvuong
    alexvuong committed May 15, 2023
    Configuration menu
    Copy the full SHA
    c619baa View commit details
    Browse the repository at this point in the history

  9. clean up

    @alexvuong
    alexvuong committed May 15, 2023
    Configuration menu
    Copy the full SHA
    6ab7ac2 View commit details
    Browse the repository at this point in the history

  10. clean up

    @alexvuong
    alexvuong committed May 15, 2023
    Configuration menu
    Copy the full SHA
    63d5656 View commit details
    Browse the repository at this point in the history

  11. address feedback

    @alexvuong
    alexvuong committed May 15, 2023
    Configuration menu
    Copy the full SHA
    047201e View commit details
    Browse the repository at this point in the history

  12. update the doc and changelog

    @alexvuong
    alexvuong committed May 15, 2023
    Configuration menu
    Copy the full SHA
    f149f3c View commit details
    Browse the repository at this point in the history