-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump-version
script: further tweaks
#1379
Conversation
- No longer incrementing the pre-release versions of the independent packages - Do list all the versions in more places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice if we could update all the packages (even those with different versions) with a single command, so we only have to wait for lerna to run once.
@@ -116,6 +113,11 @@ const updateDeps = (pkgJson) => { | |||
}) | |||
} | |||
|
|||
const listAllVersions = () => { | |||
sh.echo('\nVersions of packages in the monorepo:\n') | |||
sh.exec('lerna list --all --long') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi, using lerna
directly rather than npx lerna
or whatever means you can't node scripts/bump-version
, you have to use npm run bump-version
(or install lerna
globally, but that's gross).
@vmarta Just making sure I understand. By default, |
@vcua-mobify that's correct. The output log is like that because I want us to easily see the big picture. Yes, you're only incrementing the version of retail-react-app, but usually we'll need to think of it in the context of the entire monorepo. |
Thanks for the contribution! It looks like @vmarta is an internal user so signing the CLA is not required. However, we need to confirm this. |
This PR add the following tweaks to the
bump-version
script:npm run bump-version
, it no longer increments the pre-release versions of the independent packagesnpm run bump-version
. But now for more consistent DX, we're now doing it for the other variations too (e.g.npm run bump-version:retail-react-app
)How to test the changes