@W-14016114: Merged storefront preview into develop (v3) #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* setting cookies samesite conditionally
alexvuong
changed the title
alexvuong
changed the title
kevinxh
reviewed
Aug 30, 2023
packages/template-retail-react-app/app/components/_app/index.jsx
Outdated
Show resolved
Hide resolved
kevinxh
reviewed
Aug 30, 2023
packages/template-retail-react-app/app/components/_app/index.jsx
Outdated
Show resolved
Hide resolved
vmarta
previously approved these changes
Aug 30, 2023
packages/template-retail-react-app/app/components/_app/index.jsx
Outdated
Show resolved
Hide resolved
kevinxh
requested changes
Sep 5, 2023
There was a problem hiding this comment.
Have we considered adding the changes to pwa-kit-react-sdk?
The template files are overridable since V3, and _app is THE mostly likely overridden component in projects.
The ideal solution should prevent customer from shooting their own foot, and the SDK is a great place to ensure storefront preview always work, regardless if you override _app or not.
* Move storefront preview set up into the SDK
kevinxh
reviewed
Sep 8, 2023
Comment on lines
+39
to
+45
| const getRuntimeEnv = () => { | ||
| if (process.env.NODE_ENV !== 'production') return process.env.NODE_ENV ?? 'development' | ||
| const origin = getAppOrigin() | ||
| // mobify-storefront-staging sites have NODE_ENV set to production, but for the purposes | ||
| // of CSP we consider the sites to be staging. | ||
| return origin.endsWith('.mobify-storefront-staging.com') ? 'staging' : 'production' | ||
| } |
There was a problem hiding this comment.
(no action needed) we are going to move this code into the SDK in a future ticket
kevinxh
previously approved these changes
Sep 8, 2023
vmarta
previously approved these changes
Sep 8, 2023
vmarta
approved these changes
Sep 11, 2023
kevinxh
approved these changes
Sep 11, 2023
shethj
pushed a commit
that referenced
this pull request
Sep 12, 2023
* Create StorefrontPreview in the SDK, and set it up in the Retail app --------- Co-authored-by: Will Harney <wharney@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merging storefront preview for V3
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization