Refactor: Use 'login' for authentication instead of 'email' in registration process

[luanrafaelpinheiro]

Refactor: Use 'login' for authentication instead of 'email' in registration process

Issue #1464

Description

Types of Changes

• [ x] Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Documentation update
• Breaking change (could cause existing functionality to not work as expected)
• Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

• Removing a public function or component or prop
• Adding a required argument to a function
• Changing the data type of a function parameter or return value
• Adding a new peer dependency to package.json

Changes

• Refactoring: Use 'login' for authentication instead of 'email' in registration process

How to Test-Drive This PR

• Register a customer using a login different of the customer email.

Checklists

General

• [ x ] Changes are covered by test cases
• CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

• There are no changes to UI

or...

• Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
• Changes comply with WCAG 2.0 guidelines levels A and AA
• Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

• Changes include a UI text update in the Retail React App (which requires translation)

[wjhsf]

Currently, PWA Kit uses the same value for login and email. If the two values differ, then the value for login must be used for logging in. Therefore, I don't think that this change will break any existing code.

Thanks for the contribution @luanrafaelpinheiro! Would you mind adding this bug fix to the changelog under the 1.1.0-dev heading so that it is documented for the next release?

[luanrafaelpinheiro]

Certainly, I updated the changelog.

[kevinxh]

thank you

[wjhsf]

Uh oh, @luanrafaelpinheiro! Looks like you don't have signed commits. Could you set that up and redo the changes? Thanks!

[luanrafaelpinheiro]

Uh oh, @luanrafaelpinheiro! Looks like you don't have signed commits. Could you set that up and redo the changes? Thanks!

I need to open a new PR or just send a new signed commit?

[wjhsf]

Uh oh, @luanrafaelpinheiro! Looks like you don't have signed commits. Could you set that up and redo the changes? Thanks!

I need to open a new PR or just send a new signed commit?

All of the commits on the branch must be signed, so you could either force push to this branch or create a new one (and a new PR). Whichever way is most convenient.

[luanrafaelpinheiro]

Uh oh, @luanrafaelpinheiro! Looks like you don't have signed commits. Could you set that up and redo the changes? Thanks!

I need to open a new PR or just send a new signed commit?

All of the commits on the branch must be signed, so you could either force push to this branch or create a new one (and a new PR). Whichever way is most convenient.

done!