Add warning to pwa-kit-create-app that v2 is outdated. #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjhsf
commented
Oct 24, 2023
| @@ -421,7 +421,14 @@ const checkOutputDir = (path) => { | |||
| } | |||
| } | |||
|
|
|||
| const main = (opts) => { | |||
| const main = async (opts) => { | |||
There was a problem hiding this comment.
Note: this method already returns a promise, so changing this to an async function is of minimal consequence.
kevinxh
approved these changes
Oct 24, 2023
vmarta
approved these changes
Oct 24, 2023
| console.warn('Please use the new package to use the latest PWA Kit features.') | ||
| console.log('') | ||
| // Wait 1 second before continuing to draw attention to the warning | ||
| await new Promise((resolve) => setTimeout(resolve, 1000)) |
There was a problem hiding this comment.
Nice UX touch.. appreciate this delay 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New projects should be generated with
@salesforce/pwa-kit-create-app, but we don't want to completely break the v2 app. Solution: add a warning!An additional optional step might be to mark the package as deprecated in npm.
Description
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization