Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ssrFunctionNodeVersion to use Node 18 #1521

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

adamraya
Copy link
Collaborator

@adamraya adamraya commented Nov 3, 2023

Description

MRT only supports bundles running Node 18. The PR updates the ssrFunctionNodeVersion to use Node 18.

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • Updated ssrFunctionNodeVersion to Node 18.

How to Test-Drive This PR

  • Generate a project and verify that the ssrFunctionNodeVersion is using Node 18.
GENERATOR_PRESET=retail-react-app-demo node packages/pwa-kit-create-app/scripts/create-mobify-app-dev.js —outputDir ~/generated-project-demo

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@adamraya adamraya requested a review from a team as a code owner November 3, 2023 17:42
@adamraya adamraya merged commit 104f610 into release-2.8.x Nov 3, 2023
29 checks passed
@adamraya adamraya deleted the use-mrt-node-18 branch November 3, 2023 18:24
@wjhsf wjhsf mentioned this pull request Nov 8, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants