-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: add accessibility labels for form fields and icons @W-14337430@ #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommerceCloud/pwa-kit into ju/accessibility-form-fields
wjhsf
reviewed
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one missed message, otherwise 👍
packages/template-retail-react-app/app/components/header/index.jsx
Outdated
Show resolved
Hide resolved
packages/template-retail-react-app/app/pages/product-list/partials/color-refinements.jsx
Outdated
Show resolved
Hide resolved
packages/template-retail-react-app/app/pages/product-list/partials/color-refinements.jsx
Outdated
Show resolved
Hide resolved
joeluong-sfcc
changed the title
Fix: add accessibility labels for form fields and icons
Fix: add accessibility labels for form fields and icons @W-14337430@
Nov 13, 2023
shethj
reviewed
Nov 14, 2023
shethj
previously approved these changes
Nov 14, 2023
wjhsf
previously approved these changes
Nov 15, 2023
packages/template-retail-react-app/app/pages/product-list/partials/color-refinements.jsx
Outdated
Show resolved
Hide resolved
packages/template-retail-react-app/app/pages/product-list/partials/color-refinements.jsx
Outdated
Show resolved
Hide resolved
shethj
approved these changes
Nov 15, 2023
wjhsf
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds accessibility labels for certain form fields and icons as part of an internal accessibility audit. This PR tackles multiple accessibility issues that are tracked using the table below.
Accessibility Bug Tracking Table
packages/template-retail-react-app/app/components/header/index.jsx
packages/template-retail-react-app/app/components/quantity-picker/index.jsx
packages/template-retail-react-app/app/components/promo-popover/index.jsx
packages/template-retail-react-app/app/pages/product-list/partials/color-refinements.jsx
packages/template-retail-react-app/app/pages/product-list/index.jsx
packages/template-retail-react-app/app/components/icons/index.jsx
packages/template-retail-react-app/app/components/icons/index.jsx
packages/template-retail-react-app/app/components/icons/index.jsx
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization