W-14337923: Fix a11y color contrasts #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexvuong
commented
Nov 9, 2023
| @@ -5,5 +5,6 @@ | |||
| * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/BSD-3-Clause | |||
| */ | |||
| export default { | |||
| top: '0px -1px 3px rgba(0, 0, 0, 0.1), 0px -1px 2px rgba(0, 0, 0, 0.06)' | |||
| top: '0px -1px 3px rgba(0, 0, 0, 0.1), 0px -1px 2px rgba(0, 0, 0, 0.06)', | |||
| outline: '0 0 0 3px var(--chakra-colors-blue-500)' | |||
There was a problem hiding this comment.
Blue 500 is the minimum value of blue colors that satisfies the contrast ratio 3: 1 against #ffffff background
alexvuong
commented
Nov 9, 2023
| @@ -21,11 +21,17 @@ export default { | |||
| } | |||
| }, | |||
| variants: { | |||
| outline: { | |||
| field: { | |||
| borderColor: 'gray.500' | |||
There was a problem hiding this comment.
Gray 500 is the minimum value of blue colors that satisfies the constrast ratio 3:1 against #ffffff background
wjhsf
previously approved these changes
Nov 10, 2023
packages/template-retail-react-app/app/pages/product-list/partials/color-refinements.jsx
Outdated
Show resolved
Hide resolved
wjhsf
previously approved these changes
Nov 10, 2023
joeluong-sfcc
requested changes
Nov 10, 2023
joeluong-sfcc
approved these changes
Nov 10, 2023
shethj
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a11y color contrasts recommended in W-14337923
Major issues:
The contrast ratio of focus state color/background color not being satisfy the 3:1.
Current focus state color of component is using chakra default variable: shadows.outline. See here.
e.g:
Search input background color against adjacent color.
One of the color filter in color refinement has insufficient contrast:
The gray outline for the 'This is a gift' checkbox has insufficient color contrast against adjacent colors
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization