Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@W-12627178@ Fix outline on keyboard focus. #1536

Merged
merged 3 commits into from
Nov 15, 2023
Merged

@W-12627178@ Fix outline on keyboard focus. #1536

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fb1f66
@W-12627178@ Fix outline on keyboard focus.
wjhsf Nov 10, 2023
d1773e6
Merge branch 'develop' into wjh/keyboard-a11y-W-12627178
wjhsf Nov 14, 2023
de40447
Merge branch 'develop' into wjh/keyboard-a11y-W-12627178
wjhsf Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
32 changes: 17 additions & 15 deletions packages/template-retail-react-app/app/components/product-view/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import React, {forwardRef, useEffect, useRef, useState} from 'react'
import PropTypes from 'prop-types'
import {useHistory, useLocation} from 'react-router-dom'
import {useIntl} from 'react-intl'
import {useIntl, FormattedMessage} from 'react-intl'

import {
Flex,
Expand Down Expand Up @@ -311,13 +311,14 @@ const ProductView = forwardRef(
/>
<HideOnMobile>
{showFullLink && product && (
<Link to={`/product/${product.master.masterId}`}>
<Text color="blue.600">
{intl.formatMessage({
defaultMessage: 'See full details',
id: 'product_view.link.full_details'
})}
</Text>
<Link
to={`/product/${product.master.masterId}`}
color="blue.600"
>
<FormattedMessage
id="product_view.link.full_details"
defaultMessage="See full details"
/>
</Link>
)}
</HideOnMobile>
Expand Down Expand Up @@ -473,13 +474,14 @@ const ProductView = forwardRef(
</Box>
<HideOnDesktop>
{showFullLink && product && (
<Link to={`/product/${product.master.masterId}`}>
<Text color="blue.600">
{intl.formatMessage({
defaultMessage: 'See full details',
id: 'product_view.link.full_details'
})}
</Text>
<Link
to={`/product/${product.master.masterId}`}
color="blue.600"
>
<FormattedMessage
id="product_view.link.full_details"
defaultMessage="See full details"
/>
</Link>
)}
</HideOnDesktop>
Expand Down